Skip to content

Remove SubtitlesStream#getURL()#386

Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom
triallax:remove-subtitles-stream-get-url
Aug 26, 2020
Merged

Remove SubtitlesStream#getURL()#386
TobiGr merged 2 commits intoTeamNewPipe:devfrom
triallax:remove-subtitles-stream-get-url

Conversation

@triallax
Copy link
Contributor

@triallax triallax commented Aug 12, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Fixes #350.

wb9688
wb9688 requested changes Aug 12, 2020
View reviewed changes
Copy link
Member

@wb9688 wb9688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also remove the redundant url field from this class

@triallax triallax mentioned this pull request Aug 12, 2020
Merged
5 tasks
@triallax
Copy link
Contributor Author

triallax commented Aug 12, 2020

Will do!

@triallax
Copy link
Contributor Author

triallax commented Aug 12, 2020

Done!

@TobiGr
Copy link
Contributor

TobiGr commented Aug 12, 2020 •
edited
Loading

Just a little off-topic question: why are the class variables public in Stream?
@wb9688 Any idea? I didn't find any reason for this behaviour by searching for usages in IntelliJ.

@TobiGr TobiGr merged commit 6633f26 into TeamNewPipe:dev Aug 26, 2020
@triallax triallax deleted the remove-subtitles-stream-get-url branch August 28, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wb9688 wb9688 wb9688 requested changes

@TobiGr TobiGr TobiGr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove SubtitlesStream#getURL()

3 participants

@triallax @TobiGr @wb9688